Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Renaming rhods-dashboard-alerting.unit-tests file #1398

Merged

Conversation

biswassri
Copy link
Contributor

@biswassri biswassri commented Nov 27, 2024

Description

Renaming the rhods-dashboard-alerting.unit-tests.yaml file for successfully running make test-alerts

How Has This Been Tested?

make test-alerts

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@biswassri
Copy link
Contributor Author

/cc @jackdelahunt @StevenTobin

@biswassri biswassri changed the title fix:Renaming rhods-dashboard-alerting.unit-tests file fix: Renaming rhods-dashboard-alerting.unit-tests file Nov 27, 2024
@StevenTobin
Copy link
Contributor

I can see the dashboard alerts in the output now.

/lgtm

@jackdelahunt
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackdelahunt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (rhoai@c1952d9). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             rhoai    #1398   +/-   ##
========================================
  Coverage         ?   18.87%           
========================================
  Files            ?       30           
  Lines            ?     3338           
  Branches         ?        0           
========================================
  Hits             ?      630           
  Misses           ?     2639           
  Partials         ?       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-bot openshift-merge-bot bot merged commit 55fd878 into opendatahub-io:rhoai Nov 27, 2024
11 checks passed
@biswassri biswassri deleted the fix-dashboard-unit-test branch November 27, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants