Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Improve Operator Reconciliation #1496

Merged

Conversation

VaishnaviHire
Copy link
Member

https://issues.redhat.com/browse/RHOAISTRAT-414

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@VaishnaviHire VaishnaviHire requested a review from zdtsw January 14, 2025 06:40
@VaishnaviHire VaishnaviHire requested review from lburgazzoli and removed request for gzaronikas January 14, 2025 06:40
Copy link
Contributor

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12762436943

Copy link
Contributor

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12762437033

@VaishnaviHire VaishnaviHire force-pushed the sync_refactor_rhoai branch 4 times, most recently from 49293e6 to a488514 Compare January 14, 2025 18:43
@VaishnaviHire VaishnaviHire force-pushed the sync_refactor_rhoai branch 2 times, most recently from 458190f to a9dfb45 Compare January 14, 2025 18:59
@VaishnaviHire
Copy link
Member Author

/test opendatahub-operator-e2e

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0.24341% with 2459 lines in your changes missing coverage. Please review.

Project coverage is 20.40%. Comparing base (2de4083) to head (529af4d).
Report is 1 commits behind head on rhoai.

Files with missing lines Patch % Lines
...ers/components/kserve/kserve_controller_actions.go 0.00% 202 Missing ⚠️
controllers/components/kserve/kserve_support.go 0.00% 192 Missing ⚠️
controllers/components/kserve/kserve_controller.go 0.00% 116 Missing ⚠️
.../modelregistry/modelregistry_controller_actions.go 0.00% 110 Missing ⚠️
...mponents/dashboard/dashboard_controller_actions.go 0.00% 80 Missing ⚠️
...llers/components/dashboard/dashboard_controller.go 0.00% 78 Missing ⚠️
...lers/components/modelcontroller/modelcontroller.go 0.00% 76 Missing ⚠️
controllers/components/workbenches/workbenches.go 0.00% 74 Missing ⚠️
...ents/workbenches/workbenches_controller_actions.go 0.00% 72 Missing ⚠️
controllers/components/trustyai/trustyai.go 0.00% 67 Missing ⚠️
... and 40 more
Additional details and impacted files
@@            Coverage Diff             @@
##            rhoai    #1496      +/-   ##
==========================================
- Coverage   21.28%   20.40%   -0.88%     
==========================================
  Files          52      161     +109     
  Lines        5159    10839    +5680     
==========================================
+ Hits         1098     2212    +1114     
- Misses       3949     8392    +4443     
- Partials      112      235     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zdtsw
Copy link
Member

zdtsw commented Jan 15, 2025

/lgtm

Copy link

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit de68fa4 into opendatahub-io:rhoai Jan 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants