Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup kustomize config #1497

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jan 14, 2025

  • suspend too many WARNING lines from "make bundle"
  • remove sample config for components and monitoring

Description

follow up comments from #1487

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- suspend too many WARNING lines from "make bundle"
- remove sample config for components and monitoring

Signed-off-by: Wen Zhou <[email protected]>
@zdtsw zdtsw mentioned this pull request Jan 14, 2025
5 tasks
@zdtsw zdtsw requested review from grdryn and ykaliuta and removed request for robotmaxtron and jackdelahunt January 14, 2025 11:05
@ykaliuta
Copy link
Contributor

I doubt we should filter warnings

@zdtsw
Copy link
Member Author

zdtsw commented Jan 14, 2025

I doubt we should filter warnings

i do not know why we need keep these warnings, unless it is useful?
if it is general warnings, maybe, keep them, but this is expliclity for the config sample one.

@zdtsw
Copy link
Member Author

zdtsw commented Jan 14, 2025

/retest

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.88%. Comparing base (71f79e2) to head (e3311d4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1497   +/-   ##
=======================================
  Coverage   19.88%   19.88%           
=======================================
  Files         160      160           
  Lines       10818    10818           
=======================================
  Hits         2151     2151           
  Misses       8440     8440           
  Partials      227      227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grdryn
Copy link
Member

grdryn commented Jan 15, 2025

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 4fe5bed into opendatahub-io:main Jan 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants