-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup kustomize config #1497
chore: cleanup kustomize config #1497
Conversation
- suspend too many WARNING lines from "make bundle" - remove sample config for components and monitoring Signed-off-by: Wen Zhou <[email protected]>
I doubt we should filter warnings |
i do not know why we need keep these warnings, unless it is useful? |
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1497 +/- ##
=======================================
Coverage 19.88% 19.88%
=======================================
Files 160 160
Lines 10818 10818
=======================================
Hits 2151 2151
Misses 8440 8440
Partials 227 227 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grdryn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
4fe5bed
into
opendatahub-io:main
Description
follow up comments from #1487
How Has This Been Tested?
Screenshot or short clip
Merge criteria