-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Feast Operator component #1498
base: main
Are you sure you want to change the base?
feat: Add Feast Operator component #1498
Conversation
Signed-off-by: Abdul Hameed <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
==========================================
- Coverage 19.88% 19.64% -0.24%
==========================================
Files 160 164 +4
Lines 10818 10950 +132
==========================================
Hits 2151 2151
- Misses 8440 8572 +132
Partials 227 227 ☔ View full report in Codecov by Sentry. |
/test all |
@@ -20,6 +20,8 @@ declare -A COMPONENT_MANIFESTS=( | |||
["trainingoperator"]="opendatahub-io:training-operator:dev:manifests" | |||
["datasciencepipelines"]="opendatahub-io:data-science-pipelines-operator:main:config" | |||
["modelcontroller"]="opendatahub-io:odh-model-controller:incubating:config" | |||
["feastoperator"]="opendatahub-io:feast:master:infra/feast-operator/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["feastoperator"]="opendatahub-io:feast:master:infra/feast-operator/config" | |
["feastoperator"]="opendatahub-io:feast:v0.42.0:infra/feast-operator/config" |
can we try pointing to a versioned tag instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll still want to wait for the next release, v0.43.0, before merging this.
Description
Adding Feast Operator component for Feast Feasture Store -> https://github.com/feast-dev/feast/tree/master/infra/feast-operator
Jira : https://issues.redhat.com/browse/RHOAIENG-14792
How Has This Been Tested?
added Feast component as a Managed in dsc CR
status reflect with Ready
Operator logs
Feast installation successful as shown in below screen
Screenshot or short clip
Merge criteria