Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #222: Refactor ConfigResources Controller #277

Conversation

zack-rma
Copy link
Collaborator

Problem Description

Fixes #222.

Solution

Replaced DAO usage with OpenDCS DAI implementations.

how you tested the change

Unit tests included

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

@zack-rma zack-rma requested a review from adamkorynta December 18, 2024 22:18
@zack-rma
Copy link
Collaborator Author

Currently identifying source of DB insertion error, likely due to mapping bug

@zack-rma zack-rma requested a review from MikeNeilson January 7, 2025 20:14
@zack-rma zack-rma self-assigned this Jan 15, 2025
@zack-rma
Copy link
Collaborator Author

Closing due to newer PR with same changes: #313

@zack-rma zack-rma closed this Jan 16, 2025
@zack-rma zack-rma removed their assignment Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants