Issue #223: Implemented DataSourceResources Controller refactor #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
rma-rripken
reviewed
Dec 31, 2024
| return ads; | ||
| } | ||
|
|
||
| static ArrayList<ApiDataSourceGroupMember> map(Vector<DataSource> groupMembers) |
There was a problem hiding this comment.
@MikeNeilson is there a reason the DTO classes have to use ArrayList and Vector? Can we just fix the DTO so that we don't have to return implementation classes?
There was a problem hiding this comment.
Not really. In a few cases it's because the Original DAOs or Interfaces used Vector and they ArrayList. So there would need to be a conversion step but I would argue we should just do so.
The DAOs are going to be moved to List or Collection as the output, but we haven't gotten to it yet.
rma-rripken
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Fixes #223.
Solution
Replaced DAO usage with OpenDCS DAI implementations.
how you tested the change
Unit tests included.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.