-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor DatatypeUnitResources Controller #279
Refactor DatatypeUnitResources Controller #279
Conversation
Some methods will need to be implemented in OpenDCS to complete this task |
Quality Gate passedIssues Measures |
opendcs-rest-api/src/main/java/org/opendcs/odcsapi/res/DatatypeUnitResources.java
Outdated
Show resolved
Hide resolved
opendcs-rest-api/src/test/java/org/opendcs/odcsapi/res/DatatypeUnitResourcesTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolve the comments.
OpenDCS Toolkit changes can be found here: adamkorynta/opendcs#2 Deletion bug and Toolkit support for UnitConverter deletion on XML DB in progress. |
opendcs-rest-api/src/main/java/org/opendcs/odcsapi/res/DatatypeUnitResources.java
Outdated
Show resolved
Hide resolved
Closing due to newer PR with these changes and OpenTSDB integration testing: #315 |
Problem Description
Fixes #224.
Solution
Replaces DAO usage with OpenDCS DAI implementations.
how you tested the change
Unit tests included.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.