Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DatatypeUnitResources Controller #279

Conversation

zack-rma
Copy link
Collaborator

Problem Description

Fixes #224.

Solution

Replaces DAO usage with OpenDCS DAI implementations.

how you tested the change

Unit tests included.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

@zack-rma
Copy link
Collaborator Author

Some methods will need to be implemented in OpenDCS to complete this task

@zack-rma zack-rma self-assigned this Dec 19, 2024
Copy link
Collaborator

@rma-rripken rma-rripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve the comments.

@zack-rma
Copy link
Collaborator Author

zack-rma commented Jan 3, 2025

OpenDCS Toolkit changes can be found here: adamkorynta/opendcs#2

Deletion bug and Toolkit support for UnitConverter deletion on XML DB in progress.

@zack-rma
Copy link
Collaborator Author

Closing due to newer PR with these changes and OpenTSDB integration testing: #315

@zack-rma zack-rma closed this Jan 10, 2025
@zack-rma zack-rma removed their assignment Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants