-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign the owner as a label to the project #946
Conversation
# Labels do not allow the '@' char so let's replace it with '_at_' | ||
# For instance, [email protected] will be converted to foo_at_bar.com | ||
# resulting in the following label: ods.project.owner=foot_at_bar.com | ||
namespace_owner=$(echo "${PROJECT_ADMINS}" | cut -d "," -f1 | sed -r 's/@/_at_/g') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming PROJECT_ADMINS
is a comma-separated list of email addresses, could anyone confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are tests for this :) https://github.com/opendevstack/ods-core/blob/master/create-projects/tests/run.sh
@felipecruz91 would be great to have this in ODS 4.0. Any open questions? |
@metmajer No questions from my side. I just have to update the PR to reflect the new label name suggested by @segator here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@felipecruz91 please resolve the conflicts, then squash and merge into a single commit. Thanks |
…build-failed-due-to-missing-permission-by-reverting-PR-946 Revert "Assign the owner as a label to the project (#946)" to fix ODS AMI bulid
Refers to opendevstack/ods-provisioning-app#668