Assign the owner as a label to the project #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecruz91
commented
Jan 28, 2021
| # Labels do not allow the '@' char so let's replace it with '_at_' | ||
| # For instance, [email protected] will be converted to foo_at_bar.com | ||
| # resulting in the following label: ods.project.owner=foot_at_bar.com | ||
| namespace_owner=$(echo "${PROJECT_ADMINS}" | cut -d "," -f1 | sed -r 's/@/_at_/g') |
There was a problem hiding this comment.
I'm assuming PROJECT_ADMINS is a comma-separated list of email addresses, could anyone confirm?
There was a problem hiding this comment.
There are tests for this :) https://github.com/opendevstack/ods-core/blob/master/create-projects/tests/run.sh
|
@felipecruz91 would be great to have this in ODS 4.0. Any open questions? |
|
@metmajer No questions from my side. I just have to update the PR to reflect the new label name suggested by @segator here: |
stitakis
previously approved these changes
Mar 3, 2021
|
@felipecruz91 please resolve the conflicts, then squash and merge into a single commit. Thanks |
This was referenced Jul 19, 2021
stitakis
added a commit
that referenced
this pull request
Jul 21, 2021
…build-failed-due-to-missing-permission-by-reverting-PR-946 Revert "Assign the owner as a label to the project (#946)" to fix ODS AMI bulid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to opendevstack/ods-provisioning-app#668