Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove image wrappers #648

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Remove image wrappers #648

merged 4 commits into from
Jan 31, 2023

Conversation

michaelsauter
Copy link
Member

@michaelsauter michaelsauter commented Jan 12, 2023

With this change, images are not build in the cluster anymore. Instead, tasks use the prebuilt images on GitHub. In case of a private certificate, that is supplied via a secret volume to tasks.

Closes #621.

Tasks:

  • Updated design documents in docs/design directory or not applicable
  • Updated user-facing documentation in docs directory or not applicable
  • Ran tests (e.g. make test) or not applicable
  • Updated changelog or not applicable

@michaelsauter michaelsauter self-assigned this Jan 12, 2023
@michaelsauter michaelsauter force-pushed the feature/ghcr-images branch 7 times, most recently from d4f777f to 63fb600 Compare January 18, 2023 15:11
@michaelsauter michaelsauter changed the title WIP: Remove image wrappers Remove image wrappers Jan 30, 2023
@michaelsauter michaelsauter marked this pull request as ready for review January 30, 2023 09:05
@henrjk
Copy link
Member

henrjk commented Jan 31, 2023

Regarding the current state that python builds are using pypi and configuring nexus as a trusted host in:

pip3 config set global.trusted-host "${NEXUS_HOST}"
pip3 config set global.extra-index-url https://pypi.org/simple

To my recollection the reason this was introduced was ultimately needed due to work around cases where the pypi json api is needed. This surfaced as described in issue:

Recently PR Generate hashes for all available candidates #1723 was merged and the PR for jazzband/pip-tools#1536 (comment) which is a duplicate of 1412 mentioned is still in progress. Once that can be merged it should enable the python build to only use the configured nexus for python builds and remove the fallback of pypi.

We could consider to revisit this when the above PR 1723 gets addressed.

Just adding that I also submitted the related Dev - Nexus RepoNEXUS-22828
Support PyPI JSON API

Copy link
Member

@henrjk henrjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelsauter
Copy link
Member Author

@kuebler @gerardcl I'll merge this now in order to push new images into the registry. With those, I'll do a manual test run in our cluster. I expect a few issues here and there so maybe there will be a follow-up PR. Therefore I would appreciate your review & feedback, maybe you detect some other things in the PR that needs attention.

In general, we could be a bit more cautious before merging this, but I'll just make it as easy and fast as possible for myself to give this a spin outside tests.

If manual testing works out fine, I would create a new release soon.

@michaelsauter michaelsauter merged commit 19caf6e into master Jan 31, 2023
@michaelsauter michaelsauter deleted the feature/ghcr-images branch January 31, 2023 08:18
@michaelsauter michaelsauter mentioned this pull request Feb 16, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to remove wrapper images (again)
2 participants