This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Support between/not between operator #1067
Open
chloe-zh
wants to merge
6
commits into
opendistro-for-elasticsearch:develop
Choose a base branch
from
chloe-zh:between-operator
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support between/not between operator #1067
chloe-zh
wants to merge
6
commits into
opendistro-for-elasticsearch:develop
from
chloe-zh:between-operator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1067 +/- ##
==========================================
Coverage 99.89% 99.89%
- Complexity 2408 2432 +24
==========================================
Files 236 236
Lines 5484 5537 +53
Branches 327 338 +11
==========================================
+ Hits 5478 5531 +53
Misses 5 5
Partials 1 1 Continue to review full report at Codecov.
|
@chloe-zh this is perfect we are needed this specific feature for one of our components, any idea when this will get a release? Thanks |
@chloe-zh any update on this pull? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1058
Description of changes:
(NOT) BETWEEN ... AND ...
operator is pushdown to range query when it's in a filter expression that can be pushed down. The explanation of optimized DSL is as follows:Query
SELECT lastname, age FROM accounts WHERE age BETWEEN 20 AND 30
:And query
SELECT lastname, age FROM accounts WHERE age NOT BETWEEN 20 AND 30
:Note: this PR does not include comparison test because of different behaviors for the testing DBs, they are returning integer type (1 as true and 0 as false).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.