Skip to content

Commit

Permalink
use correct paramters
Browse files Browse the repository at this point in the history
  • Loading branch information
N-Clerkx committed Dec 14, 2023
1 parent 0b5639d commit b5539ab
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/deploy_function.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ on:
env:
PROJECT_ID: dgds-i1000482-002
GAR_LOCATION: europe-west4
SERVICE: gca-report-generation
SERVICE: gca-report-function
REPOSITORY: gca-artifacts
REGION: europe-west4 # TODO: update Cloud Run service region

jobs:
Expand Down Expand Up @@ -90,8 +91,8 @@ jobs:
- name: Build and Push Container
working-directory: App/functions/report-python-cloud-run
run: |-
docker build -t "${{ env.GAR_LOCATION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.SERVICE }}:${{ github.sha }}" .
docker push "${{ env.GAR_LOCATION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.SERVICE }}:${{ github.sha }}"
docker build -t "${{ env.GAR_LOCATION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.REPOSITORY }}:${{ github.sha }}" .
docker push "${{ env.GAR_LOCATION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.REPOSITORY }}:${{ github.sha }}"
# END - Docker auth and build

Expand All @@ -102,7 +103,7 @@ jobs:
service: ${{ env.SERVICE }}
region: ${{ env.REGION }}
# NOTE: If using a pre-built image, update the image name here
image: ${{ env.GAR_LOCATION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.SERVICE }}:${{ github.sha }}
image: ${{ env.GAR_LOCATION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.REPOSITORY }}:${{ github.sha }}

# If required, use the Cloud Run url output in later steps
- name: Show Output
Expand Down

0 comments on commit b5539ab

Please sign in to comment.