Skip to content

Commit

Permalink
fix: shellcheck review
Browse files Browse the repository at this point in the history 
Signed-off-by: Abhinandan Purkait <[email protected]>
  • Loading branch information
@Abhinandan-Purkait
Abhinandan-Purkait committed Nov 22, 2023
1 parent 61667db commit 1d5e27e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions ci/ci-test.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,8 @@ kubectl wait --for=condition=Ready --timeout=300s pods/openebs-cstor-csi-control

# Run e2e tests for csi volumes
cd ./tests/e2e

Check warning on line 59 in ci/ci-test.sh

View workflow job for this annotation

GitHub Actions / lint 

[shellcheck] reported by reviewdog 🐶
Use 'cd ... || exit' or 'cd ... || return' in case cd fails. [SC2164](https://github.com/koalaman/shellcheck/wiki/SC2164)

Raw Output:
./ci/ci-test.sh:59:1:warning:Use 'cd ... || exit' or 'cd ... || return' in case cd fails. [SC2164](https://github.com/koalaman/shellcheck/wiki/SC2164)
make e2e-test

if [ $? -ne 0 ]; then
if ! make e2e-test; then
echo "******************** CSI Controller logs***************************** "
dumpCSIControllerLogs 1000

Expand Down
8 changes: 4 additions & 4 deletions tests/e2e/Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ KUBECTL=/usr/local/bin/kubectl


# If you want to change the Kubernetes version for e2e test, specify this variable from command line.
# e.g. $ make TEST_KUBERNETES_VERSION=1.17 test
TEST_KUBERNETES_VERSION=1.17
# e.g. $ make TEST_KUBERNETES_VERSION=1.25.16 test
TEST_KUBERNETES_VERSION=1.25.16

ifeq ($(TEST_KUBERNETES_VERSION),1.17)
KUBERNETES_VERSION=1.17.2
ifeq ($(TEST_KUBERNETES_VERSION),1.25.16)
KUBERNETES_VERSION=1.25.16.2
endif


Expand Down

0 comments on commit 1d5e27e

Please sign in to comment.