Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): add gcEnable configuration to chart for PR #167 #177

Closed
wants to merge 3 commits into from
Closed

feat(helm): add gcEnable configuration to chart for PR #167 #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3869f6b
feat(helm): add gcEnable configuration to chart for PR #167
njuptlzf Dec 6, 2023
ddb9ad8
Merge branch 'develop' into gc_enable_helm
njuptlzf Dec 7, 2023
f63f3d4
update: chart version
njuptlzf Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/helm/charts/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Helm chart for OpenEBS Dynamic NFS PV. For instructions to install
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.10.2
version: 0.10.3
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.10.0
Expand Down
1 change: 1 addition & 0 deletions deploy/helm/charts/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ helm install openebs-nfs openebs-nfs/nfs-provisioner --namespace openebs --creat
| `nfsProvisioner.nfsServerNodeAffinity` | NFS Server node affinity rules | `""` |
| `nfsProvisioner.nfsBackendPvcTimeout` | Timeout for backend PVC binding in seconds | `"60"` |
| `nfsProvisioner.nfsHookConfigMap` | Existing Configmap name to load hook configuration | `""` |
| `nfsProvisioner.enableGarbageCollection` | Enable garbage collection | `true` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `nfsProvisioner.enableGarbageCollection` | Enable garbage collection | `true` |
| `nfsProvisioner.enableGarbageCollection` | Enable garbage collection for the backend PVC | `true` |

| `nfsStorageClass.backendStorageClass` | StorageClass to be used to provision the backend volume. If not specified, the default StorageClass is used. | `""` |
| `nfsStorageClass.mountOptions` | NFS mount options to be passed on to storageclass | `[]`
| `nfsStorageClass.isDefaultClass` | Make 'openebs-kernel-nfs' the default StorageClass | `"false"` |
Expand Down
4 changes: 4 additions & 0 deletions deploy/helm/charts/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@ spec:
- name: OPENEBS_IO_NFS_SERVER_NODE_AFFINITY
value: "{{ .Values.nfsProvisioner.nfsServerNodeAffinity }}"
{{- end }}
# Provide a switch to turn off the function of clearing stale pvc to avoid
# garbage collecting an NFS backend PVC if the NFS PVC is deleted.
- name: OPENEBS_IO_NFS_SERVER_GARBAGE_COLLECTION_ENABLED
value: "{{ .Values.nfsProvisioner.enableGarbageCollection }}"
Comment on lines +108 to +109
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick:

Suggested change
- name: OPENEBS_IO_NFS_SERVER_GARBAGE_COLLECTION_ENABLED
value: "{{ .Values.nfsProvisioner.enableGarbageCollection }}"
{{ if .Values.nfsProvisioner.enableGarbageCollection }}
- name: OPENEBS_IO_NFS_SERVER_GARBAGE_COLLECTION_ENABLED
value: {{ quote .Values.nfsProvisioner.enableGarbageCollection }}
{{- end }}

And on the values.yaml, the option wouldn't need quotes around it anymore

enableGarbageCollection: true

{{- if .Values.nfsProvisioner.nfsBackendPvcTimeout }}
- name: OPENEBS_IO_NFS_SERVER_BACKEND_PVC_TIMEOUT
value: "{{ .Values.nfsProvisioner.nfsBackendPvcTimeout }}"
Expand Down
3 changes: 3 additions & 0 deletions deploy/helm/charts/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ nfsProvisioner:
tag:
pullPolicy: IfNotPresent
enableLeaderElection: "true"
# Provide a switch to turn off the function of clearing stale pvc to avoid
# garbage collecting an NFS backend PVC if the NFS PVC is deleted.
enableGarbageCollection: "true"
# Specify image name of nfs-server-alpine used for creating nfs server deployment
# If not mentioned, default value openebs/nfs-server-alpine:tag will be used where
# the tag will be the same as a provisioner-nfs image tag
Expand Down
Loading