Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Commit

Permalink
fix: allow defining MFE-specific env overrides while preserving extra…
Browse files Browse the repository at this point in the history
… defaults (#7090)

(cherry picked from commit ee8a900)
  • Loading branch information
Agrendalath committed Jan 31, 2024
1 parent ea82c5a commit 65b64d4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
All notable changes to this project will be documented in this file.
Add any new changes to the top (right below this line).

- 2024-01-25
- Role: mfe
- Added `MFE_ENVIRONMENT_DEFAULT_EXTRA` to allow operators to add extra environment variables to all MFEs when
deploying them with the `mfe_deployer` role.

- 2023-04-07
- Changed default value of `EDXAPP_MONGO_REPLICA_SET` to `null` from existing
empty string `""`, to make it compatible with pymongo >= 3.11 in Nutmeg and above.
Expand Down
4 changes: 3 additions & 1 deletion playbooks/roles/mfe/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,10 @@ MFE_ENVIRONMENT_DEFAULT:

MFE_STANDALONE_NGINX: true

# This variable can be overridden to include extra defaults for all MFEs deployed with the `mfe_deployer` role.
MFE_ENVIRONMENT_DEFAULT_EXTRA: {}
# NOTE: This should be overridden by inheriting MFE-specific role.
MFE_ENVIRONMENT_EXTRA: {}
MFE_ENVIRONMENT: '{{ MFE_ENVIRONMENT_DEFAULT | combine(MFE_ENVIRONMENT_EXTRA) }}'
MFE_ENVIRONMENT: '{{ MFE_ENVIRONMENT_DEFAULT | combine(MFE_ENVIRONMENT_DEFAULT_EXTRA) | combine(MFE_ENVIRONMENT_EXTRA) }}'

MFE_NPM_OVERRIDES: []

0 comments on commit 65b64d4

Please sign in to comment.