feat: Add devstack ami playbook ISRE-1389 #6827
Conversation
|
@jdmulloy Could we add a description to this PR and do you feel it's ok to merge early and add on or should this be a draft PR? |
jdmulloy
force-pushed
the
jdmulloy/cloud_dev_stack_ami
branch
2 times, most recently
from
620e96a
to
8b407f6
Compare
It's not ready. I had to put stuff up on github to pull it down into minikube with ArgoCD/GoCD. I find it easier to work with Pull Requests and to have the link for tickets. I could have just pushed the branch I suppose. |
jdmulloy
force-pushed
the
jdmulloy/cloud_dev_stack_ami
branch
from
d3fbe73
to
ecb3e05
Compare
jdmulloy
force-pushed
the
jdmulloy/cloud_dev_stack_ami
branch
from
ecb3e05
to
b22c2a9
Compare
jdmulloy
force-pushed
the
jdmulloy/cloud_dev_stack_ami
branch
from
b22c2a9
to
00a671c
Compare
List from https://docs.docker.com/engine/install/ubuntu/ includes pacakges docker-ce docker-ce-cli containerd.io docker-compose-plugin
|
@jdmulloy I chatted about this PR with @johnnagro and @thomty this week and think it's a key piece to easing some of the pain that new engineers face. Is it ok if I book some time with you and @thomty to better understand what you think needs to happen to it before it can be merged? |
thomty
changed the title
| insertafter: EOF | ||
| dest: /home/ubuntu/.ssh/known_hosts | ||
| content: | | ||
| github.com ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIOMqqnkVzrm0SdG6UOoqKLsabgH5C9okWi0dh2l9GKJl |
There was a problem hiding this comment.
Will these ever need to be updated and should we add a comment about where we got them from?
There was a problem hiding this comment.
There's likely a better way to pull these in an automated fashion.
They're pulled from https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints
Definitely an optimization available.
| @@ -74,13 +74,13 @@ | |||
| state: "present" | |||
| when: > | |||
| ansible_distribution in common_debian_variants and | |||
| (ansible_distribution_release != 'bionic' and ansible_distribution_release != 'focal') | |||
| (ansible_distribution_release == 'precise' or ansible_distribution_release == 'trusty' or ansible_distribution_release == 'xenial') | |||
There was a problem hiding this comment.
For my own understanding this is because we are using Ubuntu 22.04 (jammy?) and this code only needs to run on three older versions of Ubuntu.
There was a problem hiding this comment.
Correct. Changing logic from not running on bionic or focal, to running only on precise, trusty, or xenial. Anything older than those 3 is well out of LTS release range.
This pull request adds the ansible framework to update a pre-existing hosted devstack AMI. It also adds support for Jammy (ubuntu 22.04) into the common aws role.
Make sure that the following steps are done before merging: