Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

feat: add authoring mfes to sandboxes #6956

Closed
wants to merge 10 commits into from

Conversation

connorhaugh
Copy link
Contributor

@connorhaugh connorhaugh commented Jul 10, 2023

Configuration Pull Request

based off of https://2u-internal.atlassian.net/wiki/spaces/FEDX/pages/11764240/How+To+Add+an+MFE+to+a+Sandbox: Step 1 was incomplete


Make sure that the following steps are done before merging:

  • A SRE team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a SRE ticket with details.
    • Add an entry to the CHANGELOG.
  • If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?

@adzuci adzuci requested a review from a team July 11, 2023 17:07
- role: splunkforwarder
when: COMMON_ENABLE_SPLUNKFORWARDER
- role: newrelic_infrastructure
when: COMMON_ENABLE_NEWRELIC_INFRASTRUCTURE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: missing new line

Copy link
Contributor

@adzuci adzuci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared this to #6641 and think it looks reasonable. Not sure if something is missing, but if it is I believe you can fix forward.

@feanil feanil closed this May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants