Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

chore: Add retry logic to prospectus npm build #6963

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

adzuci
Copy link
Contributor

@adzuci adzuci commented Jul 21, 2023

This PR attempts to make the npm build more robust by adding retry logic.

Note this is not a solution to our intermittent Algolia errors, but it may lessen the number of failed builds. The retry logic will also cause builds to run for much longer especially if npm build fails at a late stage.

Configuration Pull Request

Make sure that the following steps are done before merging:

  • A SRE team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a SRE ticket with details.
    • Add an entry to the CHANGELOG.
  • If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?

@adzuci adzuci merged commit 20bf539 into master Dec 19, 2023
3 checks passed
@adzuci adzuci deleted the adzuci/psre-2627-add-prospectus-retry-logic branch December 19, 2023 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants