Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

fix: increase compose command timeout so that devstack make commands don't fail #1066

Closed
wants to merge 56 commits into from

Conversation

XLAR-8
Copy link

@XLAR-8 XLAR-8 commented May 11, 2023

Solves issue: devstack/issues/1031

Description:
Increaing Docker Compose HTTP timeout, in seconds, so that devstack make commands do not fail.


I've completed each of the following or determined they are not applicable:

  • Made a plan to communicate any major developer interface changes (or N/A)

@openedx-webhooks
Copy link

openedx-webhooks commented May 11, 2023

Thanks for the pull request, @XLAR-8! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 11, 2023
@XLAR-8 XLAR-8 changed the title Fix- increased compose command timeout so that devstack make command. Fix- increased compose command timeout so that devstack make commands dont fail May 11, 2023
@itsjeyd
Copy link

itsjeyd commented May 16, 2023

Hi @XLAR-8, thank you for this contribution!

As the bot mentioned, the next step will be for you to sign the Open edX Contributor Agreement.

Then we can enable tests for this PR, and get it into the review queue.

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label May 16, 2023
@XLAR-8
Copy link
Author

XLAR-8 commented May 22, 2023

@itsjeyd can you please check again, I have signed contribution form ?

@itsjeyd
Copy link

itsjeyd commented May 23, 2023

Thanks for the update @XLAR-8. Could you please update the title of the PR to trigger a re-run of the CLA check?

Once you've signed the CLA, [...] you can re-run the CLA check by editing the PR title.

@XLAR-8 XLAR-8 changed the title Fix- increased compose command timeout so that devstack make commands dont fail Fix- increased compose command timeout so that devstack make commands dont fail May 24, 2023
@XLAR-8
Copy link
Author

XLAR-8 commented May 25, 2023

@itsjeyd done

@itsjeyd
Copy link

itsjeyd commented May 31, 2023

Thank you @XLAR-8!

The CLA check passed, so we're ready to move forward with next steps.

Could you please update your branch so that it includes the latest changes from master? Once that's done we'll enable CI checks for your changes.

@itsjeyd itsjeyd added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label May 31, 2023
@e0d
Copy link
Contributor

e0d commented May 31, 2023

Updating via a merge commit which will re-run the tests.

@e0d
Copy link
Contributor

e0d commented May 31, 2023

Please amend your commit messages to follow the conventional commit format described here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label May 31, 2023
@itsjeyd
Copy link

itsjeyd commented Jun 7, 2023

@XLAR-8 A friendly reminder to update your commit messages. This will fix the build :)

Once everything is green we'll line up your changes for engineering review.

@XLAR-8 XLAR-8 changed the title Fix- increased compose command timeout so that devstack make commands dont fail fix: increased compose command timeout so that devstack make commands dont fail Jun 22, 2023
@XLAR-8
Copy link
Author

XLAR-8 commented Jun 22, 2023

@itsjeyd @e0d done.

@itsjeyd
Copy link

itsjeyd commented Jun 27, 2023

@XLAR-8 Thanks for the update. It looks like one of your commit messages will need further adjustment. From the commitlint output:

⧗   input: Fix- increased compose command timeout so that devstack make commands don't fail
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings

What that tells me is that if you change

Fix- increased compose command timeout so that devstack make commands don't fail

to

fix: increase compose command timeout so that devstack make commands don't fail

... the build should turn green.

@XLAR-8 XLAR-8 changed the title fix: increased compose command timeout so that devstack make commands dont fail fix: increase compose command timeout so that devstack make commands don't fail Jul 1, 2023
@XLAR-8
Copy link
Author

XLAR-8 commented Jul 19, 2023

@itsjeyd this is done

@itsjeyd
Copy link

itsjeyd commented Jul 26, 2023

Hey @XLAR-8, it looks like you updated the title of the PR, but not the commit message? I'm still seeing Fix- increased compose command timeout so that devstack make commands don't fail on the Commits tab:

image

This page explains how to change commit messages and overwrite commits that have already been pushed to GitHub.

edx-requirements-bot and others added 5 commits July 26, 2023 23:18
…supported#1018)

* feat: target  dev image changed for LMS and Studio

* fix: env variables updated for lms and cms

* fix: rollback pip.txt changes

* fix: lms_watcher target updated
)

The paver update-db script referred to a file that was created by Ansible. This file no longer exists with the new ansible-free images.
…openedx-unsupported#1038)

Recently, as part of PR openedx-unsupported#1021, we had renamed the `dev.down` command to `dev.remove-containers` in order to try and make it a bit clearer what the command is doing behind the scenes. We still have a few commands that are trying to use the `dev.down` variant of the command. This PR updates a few remaining uses of `dev.down` to use the new syntax.
timmc-edx and others added 17 commits July 26, 2023 23:18
…nedx-unsupported#1080)

The only thing that most developers use from the devstack requirements file
is docker-compose, and that's already provided by a Docker installation on
some operating systems. So just change the Docker installation instructions
to mention docker-compose, and then drop virtualenvs from the getting
started and main workflow docs.

This commit does not change `docs/developing_on_named_release_branches.rst`
as that file is for an uncommon use-case. Removing virtualenv instructions
from that file would require getting multi-devstack set up in the first
place and then removing all the virtualenv referenves from the scripts that
are laid out in the doc. If it's worth doing that, it's best done by
someone who already uses those instructions.

Issue: openedx-unsupported#1076
This workflow adds a follow-up checklist for arch-bom
developers to use when triaging bugs.

edx/edx-arch-experiments#310
…penedx-unsupported#1099)

The e2e tests repo is deprecated and is no longer part of Open edX.
…ported#1104)

Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 5f728c3dae25f329afbe34ee4d08eef25569d79f to 411d7f9b4092af4736447c5420752e3b2be55ec1.
- [Release notes](https://github.com/peter-evans/create-or-update-comment/releases)
- [Commits](peter-evans/create-or-update-comment@5f728c3...411d7f9)

---
updated-dependencies:
- dependency-name: peter-evans/create-or-update-comment
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@itsjeyd itsjeyd added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Aug 1, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 1, 2023
@timmc-edx
Copy link
Contributor

The branch now seems to contain about 55 more commits than expected, at least according to GitHub. Maybe a rebase error?

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Aug 8, 2023
@itsjeyd
Copy link

itsjeyd commented Aug 15, 2023

Hi @XLAR-8, just checking in to see if you're still planning to work on this PR?

@itsjeyd
Copy link

itsjeyd commented Sep 13, 2023

Hi @XLAR-8! Just a quick update that I'm closing this PR now because it is stale. You may reopen this pull request, or open a new one, when you have time to come back to this work. Thanks!

@itsjeyd itsjeyd closed this Sep 13, 2023
@openedx-webhooks
Copy link

@XLAR-8 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@XLAR-8 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added closed inactivity PR was closed because the author abandoned it and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed inactivity PR was closed because the author abandoned it open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.