Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

build: Upgrade AGP to version 8.0.2 #1795

Merged
merged 5 commits into from
Jun 9, 2023
Merged

Conversation

HamzaIsrar12
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 commented Jun 5, 2023

Description

LEARNER-9330

  • Upgrade AGP to version 8.0.2.
  • Remove New Relic as it was incompatible with the latest AGP version and unused.
  • Update Kotlin to the latest supported version.
  • Update Hilt to a version that supports SDK 31.
  • Update Mockito due to incompatibility with the latest Kotlin version.
  • Reconfigure Jacoco as the previous library became outdated.

Notes

Android Studio Settings:

  • Change your Android Studio's default JDK to 17
  • Update the Android Studio's Kotlin Plugin to the latest version

Android Gradle Plugin:

Jacoco:

Mockito:

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.13 🎉

Comparison is base (80b79cc) 0.00% compared to head (4b988ea) 1.13%.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1795      +/-   ##
===========================================
+ Coverage      0.00%   1.13%   +1.13%     
- Complexity        0     137     +137     
===========================================
  Files           525     533       +8     
  Lines         24829   25198     +369     
  Branches       3029    3046      +17     
===========================================
+ Hits              0     286     +286     
- Misses        24829   24885      +56     
- Partials          0      27      +27     
Impacted Files Coverage Δ
...n/java/org/edx/mobile/authentication/LoginAPI.java 0.00% <0.00%> (ø)
...in/java/org/edx/mobile/authentication/LoginTask.kt 0.00% <ø> (ø)
...c/main/java/org/edx/mobile/base/BaseAppActivity.kt 0.00% <ø> (ø)
...rc/main/java/org/edx/mobile/base/BaseFragment.java 0.00% <ø> (ø)
...main/java/org/edx/mobile/base/MainApplication.java 0.00% <0.00%> (ø)
...org/edx/mobile/base/WebViewCourseInfoFragment.java 0.00% <0.00%> (ø)
...rg/edx/mobile/base/WebViewProgramInfoFragment.java 0.00% <0.00%> (ø)
.../main/java/org/edx/mobile/core/EdxDefaultModule.kt 0.00% <ø> (ø)
.../main/java/org/edx/mobile/core/EdxEnvironment.java 0.00% <0.00%> (ø)
...e/src/main/java/org/edx/mobile/course/CourseAPI.kt 0.00% <0.00%> (ø)
... and 144 more

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@farhan-arshad-dev farhan-arshad-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏎️ . Sqaush the commits and merge away.

@HamzaIsrar12 HamzaIsrar12 merged commit 1a7b8d6 into master Jun 9, 2023
@HamzaIsrar12 HamzaIsrar12 deleted the hamza/LEARNER-9330 branch June 9, 2023 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants