feat: add watchers to the courses #4013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfaqShuaib09
force-pushed
the
afaq/prod-3412
branch
from
cf2c10e
to
e77f4e2
Compare
| @@ -2519,6 +2527,8 @@ def handle_status_change(self, send_emails): | |||
|
|
|||
| if send_emails and email_method: | |||
| email_method(self) | |||
| if (self.course.watchers and (self.status in [CourseRunStatus.Reviewed, CourseRunStatus.Published])): | |||
| emails.send_email_for_course_url(self.course, self.go_live_date, self.status) | |||
There was a problem hiding this comment.
Once you consolidate the email methods, update it here accordingly.
There was a problem hiding this comment.
I've combined both email methods, so no need to update it.
course_discovery/apps/course_metadata/templates/course_metadata/email/watchers_course_url.html
Outdated
Show resolved
Hide resolved
AfaqShuaib09
force-pushed
the
afaq/prod-3412
branch
from
e540265
to
f727e83
Compare
AfaqShuaib09
force-pushed
the
afaq/prod-3412
branch
from
e747234
to
1658111
Compare
course_discovery/apps/course_metadata/templates/course_metadata/email/watchers_course_url.html
Outdated
Show resolved
Hide resolved
AfaqShuaib09
force-pushed
the
afaq/prod-3412
branch
from
7ea2daf
to
08a8c2d
Compare
DawoudSheraz
approved these changes
Jul 18, 2023
AfaqShuaib09
force-pushed
the
afaq/prod-3412
branch
from
98431f6
to
0032db3
Compare
AfaqShuaib09
force-pushed
the
afaq/prod-3412
branch
from
0032db3
to
884f9b1
Compare
zawan-ila
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-3412
This PR adds the watchers field to
Coursemodel and adds thewatchersfield to theCourseSerializerto add the watchers field to the API response.This PR also enables email notification for the
watchersof the course when theCourse Runof the course is published or published.Testing:
course-discovery,frontend-app-publisher,studioandecommercelocally.discoveryshellmake shell-discoverydjango-multi-email-field./manage.py migrate course_metadatato migrate the changes.Coursemodel through the Django admin.pdb.set_trace()in thesend_email_to_watchersto check if the email method is called. Because on local it will produce error due to missing email credentials.Screenshots:
Email Template:
(Write HTML file on local as it will give credential error in sending email function)