chore: python requirements update #4282
Conversation
| @@ -462,7 +462,10 @@ def test_ingest_flow_for_preexisting_published_course_with_new_run_creation(self | |||
| CourseRunFactory( | |||
| course=course, | |||
| start=datetime.datetime(2014, 3, 1, tzinfo=UTC), | |||
| end=datetime.datetime(2024, 3, 1, tzinfo=UTC), | |||
| # 2025 end date is to ensure the course run is present among active runs and thus | |||
| end=datetime.datetime(2024, 3, 1, tzinfo=UTC), | ||
| # 2025 end date is to ensure the course run is present among active runs and thus | ||
| # non-draft entries are created. If the discovery is there till 2050, you would need to update the | ||
| # tests after Jan 1, 2025. |
| @@ -46,7 +46,7 @@ def get_query_results_from_snowflake(self): | |||
| cs.execute(SNOWFLAKE_POPULATE_COURSE_LENGTH_QUERY) | |||
| rows = cs.fetchall() | |||
| for row in rows: | |||
| yield row | |||
| yield from row | |||
There was a problem hiding this comment.
Quality change -- essentially both are equivalent but pylint is being restrictive to this format.
There was a problem hiding this comment.
They are not equivalent. yield from treats row as an iterable and yields individual values from it whereas yield yields the row. As an example you can set rows = [(1,2,3), (4,5,6)] and test this.
Just looking at the snippet earlier we were yielding rows of results. With this change, I expect we'd be yielding the column values in the rows. I am confused though as to why does pylint complain about this, and why do some tests not fail here. Or maybe the tests do not check for this?
There was a problem hiding this comment.
Right, thanks for confirming. I misunderstood the docs.
The tests are essentially mocking the return value of get_query_results_from_snowflake, so that's why it is not caught by the tests.
There was a problem hiding this comment.
The data from the method is essentially a list of lists. The correct option here is yield from rows instead of yield from row
def fn3():
rows = [[1, 2, 3], [4, 5, 6]]
yield from rows
for item in fn3():
print(item)
| @@ -47,7 +47,7 @@ def get_query_results_from_snowflake(self): | |||
| cs.execute(SNOWFLAKE_REFRESH_COURSE_REVIEWS_QUERY) | |||
| rows = cs.fetchall() | |||
| for row in rows: | |||
| yield row | |||
| yield from row | |||
DawoudSheraz
force-pushed
the
jenkins/upgrade-python-requirements-9c8fd5a
branch
from
ae6cbfd
to
1596e7e
Compare
Python requirements update.Please review the changelogs for the upgraded packages.
Deleted obsolete pull_requests:
#4277