Temporary fix for translations of ES6/JSX files #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerhance
force-pushed
the
spencerhance/temp-fix-for-es6-translation
branch
2 times, most recently
from
da4100f
to
70ce681
Compare
dianakhuang
approved these changes
Aug 3, 2018
| @@ -103,15 +103,19 @@ class ProgramRecord extends React.Component { | |||
|
|
|||
| const date = new Date(isoDate); | |||
|
|
|||
| return `${date.getMonth() + 1}/${date.getDate()}/${date.getFullYear().toString().slice(2)}`; | |||
| return StringUtils.interpolate('{month}/{date}/{year}', { | |||
There was a problem hiding this comment.
I think this is okay for now, but this date may need to become localized in the future for locales that use something besides the month/day/year format.
spencerhance
force-pushed
the
spencerhance/temp-fix-for-es6-translation
branch
from
70ce681
to
bd91d52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a temporary fix for a bug in xgettext (the library that django, and consequently, our i18n tool uses for string extractions) that breaks parsing when there are backticks in the file.
All this work should eventually be reverted once we switch to a different parsing library, or xgettext adds support.
Original ticket:
https://openedx.atlassian.net/browse/LEARNER-5085
Bugs Filed:
https://openedx.atlassian.net/browse/LEARNER-6038
openedx/i18n-tools#75