Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dev note about feature toggles #1694

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

nsprenkle
Copy link
Contributor

TL;DR - I wanted a note somewhere about where ORA-specific feature toggles live. I added a brief note.

JIRA: https://openedx.atlassian.net/browse/AU-284

Developer Checklist

FYI: @edx/masters-devs-gta

@nsprenkle nsprenkle requested a review from a team as a code owner September 7, 2021 20:58
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 better late than never?

  • I tested this by reading the rendered docs change, and verified that the added documentation is still correct.
  • I read through the code
  • Updates documentation

@pomegranited pomegranited enabled auto-merge (squash) January 2, 2025 01:35
@pomegranited pomegranited requested a review from a team as a code owner January 2, 2025 02:08
@pomegranited pomegranited disabled auto-merge January 2, 2025 02:11
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (a1710f0) to head (ab433e3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1694   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         195      195           
  Lines       21624    21624           
  Branches     1502     1502           
=======================================
  Hits        20606    20606           
  Misses        771      771           
  Partials      247      247           
Flag Coverage Δ
unittests 95.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pomegranited pomegranited merged commit a674fc0 into master Jan 10, 2025
11 checks passed
@pomegranited pomegranited deleted the nsprenkle/waffle-flag-docs branch January 10, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants