Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forming Response Files link in the report #1982

Merged

Conversation

DmytroAlipov
Copy link
Contributor

@DmytroAlipov DmytroAlipov commented Jun 22, 2023

TL;DR - This is a fix forming "Response Files" link in the reports (in the context of the ORA functionality).

What changed?
The link in the formed report doesn't allow checking the uploaded file in the installation server for Instructor:

image-12

image-9

image-10

Correspond link allows to download file for instructor:

image-11

I rechecked S3 storage forming link too. It works correctly.

Developer Checklist

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@DmytroAlipov DmytroAlipov requested a review from a team as a code owner June 22, 2023 15:13
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 22, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@itsjeyd
Copy link

itsjeyd commented Jun 27, 2023

@DmytroAlipov Thanks for the contribution! Is it ready for review?

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jun 27, 2023
@DmytroAlipov
Copy link
Contributor Author

Hi @itsjeyd. Yes of course ;)

@itsjeyd
Copy link

itsjeyd commented Jun 27, 2023

@DmytroAlipov OK great, we'll get tests enabled for you next.

@itsjeyd itsjeyd added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (20626e4) 94.98% compared to head (eccc020) 95.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1982      +/-   ##
==========================================
+ Coverage   94.98%   95.01%   +0.02%     
==========================================
  Files         154      154              
  Lines       17056    17060       +4     
  Branches     1611     1610       -1     
==========================================
+ Hits        16201    16209       +8     
+ Misses        641      638       -3     
+ Partials      214      213       -1     
Flag Coverage Δ
unittests 95.01% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openassessment/data.py 90.60% <100.00%> (+0.67%) ⬆️
openassessment/tests/test_data.py 99.18% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@e0d
Copy link

e0d commented Jun 29, 2023

@DmytroAlipov it looks like there's a unit test error that needs attention.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 29, 2023
@DmytroAlipov DmytroAlipov force-pushed the fix-forming-response-files-link branch 2 times, most recently from 1af28f0 to eccc020 Compare July 3, 2023 06:51
@DmytroAlipov
Copy link
Contributor Author

@e0d Hi! There was a small problem with linting due to an unused variable, but I have fixed it. Could you please run the tests again?

@itsjeyd itsjeyd added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 5, 2023
@e0d
Copy link

e0d commented Jul 5, 2023

@DmytroAlipov We are 🟢

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 5, 2023
@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jul 11, 2023
@itsjeyd
Copy link

itsjeyd commented Jul 11, 2023

Hi @mattcarter, this PR is ready for review by the Aurora team.

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@mattcarter mattcarter merged commit 1dcc022 into openedx:master Aug 2, 2023
6 checks passed
@DmytroAlipov DmytroAlipov deleted the fix-forming-response-files-link branch August 3, 2023 06:19
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 8, 2023
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants