Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make studio UI aware of override #1989

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Conversation

jansenk
Copy link
Contributor

@jansenk jansenk commented Jul 14, 2023

TL;DR - Make ORA studio UI aware of flexible course-wide override

JIRA: https://2u-internal.atlassian.net/browse/AU-1322

What changed?

  • Add override to studio context
  • If it's enabled, disable the select box for flexbile grading
  • If it's enabled, show a message that the setting is enabled.

Developer Checklist

Testing Instructions

  • Navigate to an ORA with a peer step in a course with the override turned off. The flexible setting should be active and there should be no message about the override.
  • Turn the override on
  • The input in the ORA settings should now be disabled and there should be a warning message.

Screenshot 2023-07-14 at 11 34 31 AM

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@jansenk jansenk requested a review from a team as a code owner July 14, 2023 15:38
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f9355d1) 94.99% compared to head (c34365f) 94.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1989   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         155      155           
  Lines       17107    17108    +1     
  Branches     1616     1616           
=======================================
+ Hits        16250    16251    +1     
  Misses        642      642           
  Partials      215      215           
Flag Coverage Δ
unittests 94.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openassessment/__init__.py 100.00% <100.00%> (ø)
openassessment/xblock/studio_mixin.py 93.22% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@leangseu-edx leangseu-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jansenk jansenk merged commit 57615ac into master Jul 19, 2023
5 of 6 checks passed
@jansenk jansenk deleted the jkantor/ora-flex-studio branch July 19, 2023 13:55
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
* feat: make studio UI aware of override

* style: quality

* chore: generate static files

* chore: regenerate translations

* chore: bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants