Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump the version. #2015

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
os: [ubuntu-20.04]
python-version: ['3.8']
node-version: [16]
toxenv: [quality, js, django32]
toxenv: [quality, js, django32, django42]

steps:
- uses: actions/checkout@v2
Expand Down
22 changes: 11 additions & 11 deletions openassessment/assessment/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from openassessment.assessment.serializers import RubricSerializer


@admin.register(Rubric)
class RubricAdmin(admin.ModelAdmin):
"""
Django admin model for Rubrics.
Expand Down Expand Up @@ -55,6 +56,7 @@ class PeerWorkflowItemInline(admin.StackedInline):
extra = 0


@admin.register(PeerWorkflow)
class PeerWorkflowAdmin(admin.ModelAdmin):
"""
Django admin model for PeerWorkflows.
Expand All @@ -69,6 +71,7 @@ class PeerWorkflowAdmin(admin.ModelAdmin):
inlines = (PeerWorkflowItemInline,)


@admin.register(Assessment)
class AssessmentAdmin(admin.ModelAdmin):
"""
Django admin model for Assessments.
Expand All @@ -88,6 +91,10 @@ class AssessmentAdmin(admin.ModelAdmin):
)
exclude = ('rubric', 'submission_uuid')

@admin.display(
description='Rubric',
ordering='rubric__content_hash',
)
def rubric_link(self, assessment_obj):
"""
Returns the rubric link for this assessment.
Expand All @@ -98,8 +105,6 @@ def rubric_link(self, assessment_obj):
)
return format_html(
'<a href="{}">{}</a>', url, assessment_obj.rubric.content_hash)
rubric_link.admin_order_field = 'rubric__content_hash'
rubric_link.short_description = 'Rubric'

def parts_summary(self, assessment_obj):
"""
Expand All @@ -116,6 +121,7 @@ def parts_summary(self, assessment_obj):
) for part in assessment_obj.parts.all()))


@admin.register(AssessmentFeedback)
class AssessmentFeedbackAdmin(admin.ModelAdmin):
"""
Django admin model for AssessmentFeedbacks.
Expand All @@ -137,6 +143,7 @@ def assessments_by(self, assessment_feedback):
))


@admin.register(SharedFileUpload)
class SharedFileUploadAdmin(admin.ModelAdmin):
"""
Django admin model for SharedFileUploads.
Expand All @@ -151,24 +158,17 @@ class SharedFileUploadAdmin(admin.ModelAdmin):
)


@admin.register(StaffWorkflow)
class StaffWorkflowAdmin(admin.ModelAdmin):
"""
Django admin model for StaffWorkflows
"""
list_display = ('id', 'submission_uuid', 'course_id', 'item_id', 'grading_completed_at')


@admin.register(TeamStaffWorkflow)
class TeamStaffWorkflowAdmin(admin.ModelAdmin):
"""
Django admin model for TeamStaffWorkflows
"""
list_display = ('id', 'team_submission_uuid', 'course_id', 'item_id', 'grading_completed_at')


admin.site.register(Rubric, RubricAdmin)
admin.site.register(PeerWorkflow, PeerWorkflowAdmin)
admin.site.register(Assessment, AssessmentAdmin)
admin.site.register(AssessmentFeedback, AssessmentFeedbackAdmin)
admin.site.register(SharedFileUpload, SharedFileUploadAdmin)
admin.site.register(StaffWorkflow, StaffWorkflowAdmin)
admin.site.register(TeamStaffWorkflow, TeamStaffWorkflowAdmin)
8 changes: 4 additions & 4 deletions openassessment/staffgrader/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from openassessment.staffgrader.models import SubmissionGradingLock


@admin.register(SubmissionGradingLock)
class SubmissionGradingLockAdmin(admin.ModelAdmin):
"""
Django admin model for SubmissionGradingLock.
Expand All @@ -15,9 +16,8 @@ class SubmissionGradingLockAdmin(admin.ModelAdmin):
search_fields = ('submission_uuid',)

# This allows us to have the nice boolean check/x icons in the list rather than "True"/"False"
@admin.display(
boolean=True
)
def is_active(self, lock):
return lock.is_active
is_active.boolean = True


admin.site.register(SubmissionGradingLock, SubmissionGradingLockAdmin)
6 changes: 2 additions & 4 deletions openassessment/workflow/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ class AssessmentWorkflowStepInline(admin.StackedInline):
extra = 0


@admin.register(AssessmentWorkflow)
class AssessmentWorkflowAdmin(admin.ModelAdmin):
"""Admin for the user's overall workflow through open assessment.

Expand All @@ -28,6 +29,7 @@ class AssessmentWorkflowAdmin(admin.ModelAdmin):
inlines = (AssessmentWorkflowStepInline,)


@admin.register(TeamAssessmentWorkflow)
class TeamAssessmentWorkflowAdmin(admin.ModelAdmin):
"""
Admin for TeamAssessmentWorkflows.
Expand All @@ -40,7 +42,3 @@ class TeamAssessmentWorkflowAdmin(admin.ModelAdmin):
search_fields = ('team_submission_uuid', 'submission_uuid', 'course_id', 'item_id')

inlines = (AssessmentWorkflowStepInline,)


admin.site.register(AssessmentWorkflow, AssessmentWorkflowAdmin)
admin.site.register(TeamAssessmentWorkflow, TeamAssessmentWorkflowAdmin)
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
[tox]
envlist = py38-django{32,40}
envlist = py38-django{32,42}

[testenv]
deps =
-rrequirements/test.txt
django32: Django>=3.2,<4.0
django40: Django>=4.0,<4.1
django42: Django>=4.2,<4.3

commands =
pytest
Expand Down
3 changes: 1 addition & 2 deletions urls.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import workbench.urls

from django.conf.urls import include
from django.contrib import admin
from django.urls import re_path
from django.urls import re_path, include
from django.views.i18n import JavaScriptCatalog

import openassessment.assessment.urls
Expand Down
Loading