Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django upgrade 4.2 #318

Merged
merged 6 commits into from
Jul 20, 2023
Merged

Django upgrade 4.2 #318

merged 6 commits into from
Jul 20, 2023

Conversation

salman2013
Copy link
Contributor

Description:

  • Add support for Django 4.2

Codemod used to upgrade this repo: https://github.com/adamchainz/django-upgrade

Ticket: edx/upgrades#153

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 23, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @salman2013! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@salman2013 salman2013 closed this Jul 3, 2023
@salman2013 salman2013 reopened this Jul 3, 2023
@@ -27,6 +27,9 @@ def get_actions(self, request):

return actions

@admin.action(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link the release notes for this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salman2013 salman2013 closed this Jul 6, 2023
@salman2013 salman2013 reopened this Jul 6, 2023
@mphilbrick211
Copy link

Hi @salman2013 and @UsamaSadiq! Just following up on this.

@salman2013 salman2013 merged commit 494b9c0 into master Jul 20, 2023
16 checks passed
@salman2013 salman2013 deleted the salman/django-4.2-upgrade branch July 20, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants