build: update django-simple-history package version #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awais786
reviewed
Jul 27, 2023
awais786
reviewed
Jul 27, 2023
| @@ -0,0 +1,21 @@ | |||
| """ | |||
| Tests for migrations, especially potentially risky data migrations. | |||
There was a problem hiding this comment.
Adding test for checking migrations are in sync.
awais786
reviewed
Jul 27, 2023
| @@ -49,3 +49,6 @@ | |||
| } | |||
| }, | |||
| ] | |||
|
|
|||
| # disable indexing on date field via django-simple-history. | |||
| SIMPLE_HISTORY_DATE_INDEX = False | |||
There was a problem hiding this comment.
awais786
force-pushed
the
update-simple-history-package-version
branch
from
f20cc8a
to
48cca51
Compare
awais786
approved these changes
Aug 8, 2023
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the attempt to upgrade
historypackage in theedx-platformrepo, the check-migrations-test encountered a failure with new migrations. The updated package includes some enhancements that introduce new migrations. However, these migrations do not involve any alterations to the existing fields; instead, they are focused on meta changes aimed at improving the ordering functionality e.goptions={'get_latest_by': ('history_date', 'history_id'https://django-simple-history.readthedocs.io/en/latest/#section-1
Upgrading the package to
3.1.1While try to upgrade this package in
edx-platformit generates lots of migrations in/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/enterprise/migrationsThese are due to the package. Related PR jazzband/django-simple-history#862 ( this pr shows the get_latest_by usage )
Similar PR merged in credentials