Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: copy from node_modules using NPM postinstall hook, not Paver (RE-MERGE) #32767

Merged
merged 2 commits into from
Jul 20, 2023
Merged

build: copy from node_modules using NPM postinstall hook, not Paver (RE-MERGE) #32767

merged 2 commits into from
Jul 20, 2023

Commits on Jul 20, 2023

  1. build: copy from node_modules using NPM postinstall hook, not Paver (… 

    …RE-MERGE)

Re-merge of 4b64d83

The commit after this one contains the fix for the issue that led to the
revert.
    @kdmccormick
    kdmccormick committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    7df75a8 View commit details
    Browse the repository at this point in the history

  2. build: ensure that non-Tutor systems handle copy-node-modules.sh 

    Two fixes:

* In the (in-repo, non-Tutor) Dockerfile, add copy-node-modules.sh
  before `npm install`, since it is needed by the new postinstall hook.

* In paver/assets.py, run copy-node-modules.sh for backwards com-
  patibility, just for cases where `SKIP_NPM_INSTALL` is enabled
  (which would prevent our new postinstall hook from running
  automatically!). We will deprecate the paver asset commands all at
  once once the new non-paver stuff is 100% working.
    @kdmccormick
    kdmccormick committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    fd8e5e5 View commit details
    Browse the repository at this point in the history