Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pull_translations: use less Makefile commands and move it to Python | FC-0012 #34257

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Feb 19, 2024

mkdir should be in Python also replacing cp -r with a cms command to avoid confusing future maintainers. These are notes from Regis on Tutor, but needs an edx-platform fix.

Testing

  • Run lms make OPENEDX_ATLAS_PULL=yes pull_translations on your devstack and it should pull translations.

Deadline

As soon as possible, to meet FC-0012 timeline and help merge Tutor PR:

Other information

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 19, 2024
@OmarIthawi OmarIthawi changed the title chore: pull_translations: use less Makefile commands and move it to Python chore: pull_translations: use less Makefile commands and move it to Python | FC-0012 Feb 20, 2024
@OmarIthawi
Copy link
Member Author

@feanil this is a minor pull request that I'd love a quick review for.

@shadinaif please also verify locally so we have two testers.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@feanil feanil merged commit 92cde34 into openedx:master Feb 20, 2024
46 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@OmarIthawi
Copy link
Member Author

Thanks @feanil!!

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants