Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide library_v2 and itembank in legacy library page #35772

Merged

Conversation

navinkarkera
Copy link
Contributor

Description

Hide options to add library_v2 and itembank blocks in legacy library page.

Fix for: openedx/modular-learning#238

Supporting information

Testing instructions

  • Verify that new library content and Problem bank options are not available in any legacy library page.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 5, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 5, 2024

Thanks for the pull request, @navinkarkera!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link
Contributor

@DanielVZ96 DanielVZ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! please remember to rebase or merge master into your branch before merging:+1:

  • I tested this: (describe what you tested)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@navinkarkera navinkarkera force-pushed the navin/hide-library-blocks-in-legacy branch from 0f7eb29 to 31f8f87 Compare November 6, 2024 05:46
Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @navinkarkera!

  • I tested this using the instructions from the PR
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation

@navinkarkera navinkarkera force-pushed the navin/hide-library-blocks-in-legacy branch from 31f8f87 to 0a425bc Compare November 7, 2024 13:55
@navinkarkera navinkarkera enabled auto-merge (rebase) November 7, 2024 13:55
@navinkarkera navinkarkera force-pushed the navin/hide-library-blocks-in-legacy branch from 0a425bc to 9e1f553 Compare November 7, 2024 13:58
@navinkarkera navinkarkera force-pushed the navin/hide-library-blocks-in-legacy branch from 9e1f553 to 0c01610 Compare November 7, 2024 14:56
@navinkarkera navinkarkera enabled auto-merge (rebase) November 7, 2024 15:26
Hide options to add library_v2 and itembank blocks in legacy library
page.
@navinkarkera navinkarkera force-pushed the navin/hide-library-blocks-in-legacy branch from 0c01610 to b07cac8 Compare November 8, 2024 11:11
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works exactly as described, thank you @navinkarkera !

  • I tested this on my tutor dev stack using the PR test instructions
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

@navinkarkera navinkarkera merged commit 68739ce into openedx:master Nov 12, 2024
51 checks passed
@navinkarkera navinkarkera deleted the navin/hide-library-blocks-in-legacy branch November 12, 2024 15:06
navinkarkera added a commit to open-craft/edx-platform that referenced this pull request Nov 12, 2024
Hide options to add library_v2 and itembank blocks in legacy library
page.

(cherry picked from commit 68739ce)
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been rolled back from the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants