feat!: Removing the long-deprecated legacy course_modes chooser #36156
Conversation
`course_modes/choose.html` (and its corresponding `_upgrade_button.html`) were specifically only used for the edge case where an enterprise user found themselves in the non-enterprise learner dashboard, and attempted to enroll in a course outside of the enterprise flow. Once upon a time, in a 2U-only workflow, the commerce system would apply specific discounts for users within the said case. That's no longer true, and it has never been true outside of this one company. Removing this template cleans up a legacy version of a legacy page that was, realistically, exclusively seen by employees of 2U, and nobody else. FIXES: APER-3779
Removing the tests for the legacy chooser.
There was a problem hiding this comment.
Looks good to me! I tried looking into what needs to be done to update translations, you mentioned privately that you ran a command but didn't get any changes to appear in the terminal, right?
https://github.com/openedx/openedx-atlas?tab=readme-ov-file#usage-examples
|
this will fulfill #36090 |
Removes: * The corresponding testsfor behavior only seen in the legacy page. * A waffle flag since all cases route as if the flag is set: `VALUE_PROP_TRACK_SELECTION_FLAG`: `course_modes.use_new_track_selection` * Some variables set in `CourseModeView` which were only ever rendered in the legacy template (`title_content`, `has_credit_upsell`) have been removed from the class. * There is a high likelihood that the class is still a target for re-factoring now that the legacy view is gone, but I'm hesitant to touch something which is not covered by previously existing tests, because the logic around what template gets rendered when is complex. FIXES: APER-3779 FIXES: #36090
removing unused imports
deborahgu
deleted the
dkaplan1/APER-3779_remove-legacy-track-selection-page
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
course_modes/choose.html(and its corresponding_upgrade_button.html) were specifically only used for the edge case where an enterprise user found themselves in the non-enterprise learner dashboard, and attempted to enroll in a course outside of the enterprise flow. Once upon a time, in a 2U-only workflow, the commerce system would apply specific discounts for users within the said case. That's no longer true, and it has never been true outside of this one company.Removing this template cleans up a legacy version of a legacy page that was, realistically, exclusively seen by employees of 2U, and nobody else.
Removes:
VALUE_PROP_TRACK_SELECTION_FLAG:course_modes.use_new_track_selectionCourseModeViewwhich were only ever rendered in the legacy template (title_content,has_credit_upsell) have been removed from the class.FIXES: APER-3779
FIXES: #36090