fix: bump frontend-lib-content-components to 2.5.1 #1174
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/redwood.master #1174 +/- ##
==============================================================
Coverage ? 92.32%
==============================================================
Files ? 708
Lines ? 12540
Branches ? 2690
==============================================================
Hits ? 11577
Misses ? 926
Partials ? 37 ☔ View full report in Codecov by Sentry. |
kdmccormick
added
the
create-sandbox
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
There was a problem hiding this comment.
Thanks @KristinAoki , just a couple notes. I'll test this with the PR sandbox in the meantime.
| @@ -48,18 +52,32 @@ const courseUpdatesInitialValues = (requestType) => { | |||
| }; | |||
|
|
|||
| const renderComponent = ({ requestType }) => render( | |||
| <IntlProvider locale="en"> | |||
There was a problem hiding this comment.
Are these course-updates changes necessary?
There was a problem hiding this comment.
yes, because of the changes to the editor props. The editors for the course updates page use the same Tiny MCE editors
Co-authored-by: Kyle McCormick <[email protected]>
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
|
Quick tip, when bumping a package several version, you can link to whole set of changes by writing the URL |
There was a problem hiding this comment.
I tested all three editors, and this looks good to me. Thanks Kristin!
I also verified the image paste and insert fix fix that this PR will bring in 🚀
I am going to edit your commit message when I merge to explain that we are backporting this bump in order to remove the feedback link.
kdmccormick
deleted the
KristinAoki/backport-frontend-lib-content-components-upgrade-2.5.1
branch
The primary purpose of this version bump backport is to remove the 2U feedback form link from the editors (openedx/frontend-lib-content-components#476), but several other improvements will also be pulled in: * Fix the Text editor so that when an image is added, it is added at the cursor, instead of the beginning of the component. * Improve editor load time by reducing API calls and switching some calls to be lazy. * Align controls better in the group feedback component. * Add validation for start & stop date fields. * Fix image handling bugs in both the raw & visual text editors. Full changelog: openedx/frontend-lib-content-components@v2.1.11...v2.5.1 Co-authored-by: Kyle McCormick <[email protected]>
Settings
Description
This is a backport to include the resolution of
frontend-lib-content-components#476This upgrade includes the following version updates:
See
frontend-lib-content-componentstagged releases for more information on individual tags.