Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: confirmation window is displayed after save for dropdown #1278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export const checkForNoAnswers = ({ openSaveWarningModal, problem }) => {
let correctAnswer;
answers.forEach(answer => {
if (answer.correct) {
const title = simpleTextAreaProblems.includes(problemType) ? answer.title : answerTitles[answer.id];
const title = simpleTextAreaProblems.includes(problemType) ? answer.title.toString() : answerTitles[answer.id];
if (title.length > 0) {
correctAnswer = true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -360,5 +360,21 @@ describe('EditProblemView hooks parseState', () => {
expect(openSaveWarningModal).toHaveBeenCalled();
expect(content).toEqual(null);
});
it('should return the correct content if the user entered a number as the correct answer for a dropdown type problem', () => {
const problem = { ...problemState, answers: [{ id: 'A', title: 1234, correct: true }] };
const content = hooks.getContent({
isAdvancedProblemType: false,
problemState: problem,
editorRef,
assets,
lmsEndpointUrl,
openSaveWarningModal,
});
expect(openSaveWarningModal).toHaveBeenCalled();
expect(content).toEqual({
olx: mockBuiltOLX,
settings: expectedSettings,
});
});
});
});