Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove extra margin around body element (backport form master) #194

Open
wants to merge 2 commits into
base: open-release/quince.master
Choose a base branch
from

Conversation

Lunyachek
Copy link

This is backport from master - #193

This pull request proposes fixing the margin around the body element. This margin comes from the tinyMCE styles. In cases where we don't have a custom theme, and the header and footer are white, it's not noticeable (1st screenshot). However, if the header and footer have any color, it immediately stands out (2nd and 3rd screenshots). The important property is set not by chance, as without it, the styles from the tinyMCE override the styles from the index.scss file.

Снимок экрана 2024-02-19 в 17 02 09
Снимок экрана 2024-02-15 в 11 37 22
Снимок экрана 2024-02-15 в 11 38 08

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 19, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@39c18ac). Click here to learn what that means.

❗ Current head 5ee570d differs from pull request most recent head 2609f69. Consider uploading reports for the commit 2609f69 to get more accurate results

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #194   +/-   ##
=============================================================
  Coverage                              ?   83.06%           
=============================================================
  Files                                 ?       46           
  Lines                                 ?      685           
  Branches                              ?      132           
=============================================================
  Hits                                  ?      569           
  Misses                                ?      116           
  Partials                              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Mar 20, 2024
@mphilbrick211 mphilbrick211 requested a review from a team March 20, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Status: Backlog
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants