Hook unit tests #169
Hook unit tests #169
Conversation
muselesscreator
force-pushed
the
bw/documentation
branch
from
6be1173 to
34ae508
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 71.86% 81.63% +9.76%
==========================================
Files 164 148 -16
Lines 1905 1693 -212
Branches 459 392 -67
==========================================
+ Hits 1369 1382 +13
+ Misses 491 293 -198
+ Partials 45 18 -27 ☔ View full report in Codecov by Sentry. |
| @@ -61,6 +61,7 @@ const useFinishedStateActions = () => { | |||
| // and there are no more assessments available for the current step | |||
| return { primary: exitAction }; | |||
| } | |||
| console.log({ primary: startStepAction, secondary: exitAction }); | |||
There was a problem hiding this comment.
| console.log({ primary: startStepAction, secondary: exitAction }); |
| behavior: 'smooth', | ||
| }); | ||
| }, [hasSubmitted, step]); | ||
| if (isMounted.current) { |
There was a problem hiding this comment.
isn't useIsMounted here redundant?
There was a problem hiding this comment.
goal here is checking if still mounted, not if mounted yet
| ...selectors, | ||
| useStepState, | ||
| useXBlockState, | ||
| useActiveStepConfig, | ||
| useGlobalState, | ||
| }); | ||
| console.log({ exportedSelectors: exported }); |
There was a problem hiding this comment.
| console.log({ exportedSelectors: exported }); |
muselesscreator
force-pushed
the
bw/documentation
branch
from
758121e to
21c84cc
Compare
leangseu-edx
force-pushed
the
bw/documentation
branch
from
c48ff40 to
bb3e439
Compare
|
Thanks for the pull request, @muselesscreator! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the |
openedx-webhooks
added
the
open-source-contribution
leangseu-edx
force-pushed
the
bw/documentation
branch
from
bb3e439 to
d73d03b
Compare
|
@muselesscreator 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Adds testing coverage for the hooks directory.