Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix message title case #173

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Jan 12, 2024

I used regex to find these message.

([A-Z][^\s]*) ([A-Z][^\s]*)

https://2u-internal.atlassian.net/browse/AU-1645

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (b727624) 75.67% compared to head (7b5127d) 75.34%.
Report is 7 commits behind head on master.

Files Patch % Lines
.../views/SubmissionView/TextResponseEditor/index.jsx 0.00% 6 Missing ⚠️
...SubmissionView/TextResponseEditor/LaTexPreview.jsx 33.33% 4 Missing ⚠️
src/components/TextResponse/index.jsx 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   75.67%   75.34%   -0.34%     
==========================================
  Files         149      150       +1     
  Lines        1739     1756      +17     
  Branches      412      416       +4     
==========================================
+ Hits         1316     1323       +7     
- Misses        378      388      +10     
  Partials       45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@leangseu-edx leangseu-edx force-pushed the lk/fix-message-title-case branch from 7b5127d to f0a1972 Compare January 16, 2024 16:19
@leangseu-edx leangseu-edx merged commit 3900f61 into master Jan 16, 2024
4 checks passed
@leangseu-edx leangseu-edx deleted the lk/fix-message-title-case branch January 16, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants