chore: prevent step from clickable when the date for the step is invalid #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
nsprenkle
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Have reviewed changes with my backend PR (openedx/edx-ora2#2168) and they seem to work as expected.
Though we might want to figure out a nicer way of getting out of the edge case where a student tries to move to a step right after the due date and they just get into an error loop until they go back to the XBlock view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission hasn't started:
Submission has ended:
Self assessment hasn't started:
Self assessment has ended:
When you try to access the step modal manually when it is unavailable
peer should behavior like self step.