lk/grade implementation #67
Conversation
leangseu-edx
commented
Oct 24, 2023
•
leangseu-edx
commented
- feat: implement grade route
leangseu-edx
force-pushed
the
lk/grade-implementation
branch
from
a687a54 to
b18d722
Compare
|
Peer assessments should be listed within the collapsible, not each get their own. |
The problem with that is that peer have multiple grades and the figma expect a single peer. |
No, the figma references a multi-peer response. Reviewing the |
There was a problem hiding this comment.
Update makes sense for multiple peers. I approve, but would like @muselesscreator to check before you merge
leangseu-edx
force-pushed
the
lk/grade-implementation
branch
from
fb4cf6c to
2b82b78
Compare
src/views/GradeView/FinalGrade.jsx
Outdated
| } | ||
| if (assessments.peer) { | ||
| finalStepScore = finalStepScore || assessments.peer.stepScore; | ||
| const stepName = formatMessage(messages.peerStep); |
There was a problem hiding this comment.
pls use stepLabel if you are talking about a message. Mostly because we have a global data object called stepNames and use that as a key in many places.
src/views/GradeView/FinalGrade.jsx
Outdated
| stepName={stepName} | ||
| stepScore={assessments.peerUnweighted.stepScore} | ||
| > | ||
| {assessments.peerUnweighted.assessment?.map((peer, index) => ( |
There was a problem hiding this comment.
this should be assessments for peer and peerUnweighted. should be reflected in both the components and the mock data.
src/data/services/lms/hooks/data.ts
Outdated
| const data = loadState({ view, progressKey }); | ||
| const result = { | ||
| ...camelCaseObject(data), | ||
| }; |
There was a problem hiding this comment.
needed to selective camelize earlier with selected option and forgot to change back.
| <h5 className='mb-0'>{criterionName}</h5> | ||
| <InfoPopover onClick={() => {}}> | ||
| <p> | ||
| Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do |
There was a problem hiding this comment.
uuuuugh. we need to get these messages still
There was a problem hiding this comment.
Actually, these messages should come from the ora config data, as in the ESG rubric
leangseu-edx
force-pushed
the
lk/grade-implementation
branch
from
966b2cb to
d1a99d1
Compare
