Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add grey color for disabled selects during the form submission #715

Merged
merged 2 commits into from
May 16, 2024
Merged

feat: Add grey color for disabled selects during the form submission #715

merged 2 commits into from
May 16, 2024

Conversation

Lunyachek
Copy link
Contributor

Description

This cosmetic enhancement for payment form. After pressing "Place Order" button - we can see that all inputs became disabled, but selects - no. It looks not consistent and we decided to fix this small issue.

2023-03-06.11.53.26.mov

The result:

2023-03-02.14.43.17.mov

@Lunyachek Lunyachek requested a review from a team as a code owner March 6, 2023 10:51
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 6, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 6, 2023 •
edited
Loading

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Lunyachek Lunyachek mentioned this pull request Mar 6, 2023
Closed
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 7, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 7, 2023
@colinbrash
Copy link

colinbrash commented Mar 8, 2023 •
edited
Loading

@Lunyachek thank you for this contribution! Please take a look at this comment on #716, thanks

@mphilbrick211
Copy link

@Lunyachek thank you for this contribution! Please take a look at this comment on #716, thanks

Hi @Lunyachek - just checking in on this to see if you have any additional questions.

@mphilbrick211
Copy link

@Lunyachek thank you for this contribution! Please take a look at this comment on #716, thanks

@Lunyachek - friendly ping on this!

@mphilbrick211
Copy link

Hi @Lunyachek - just checking in to see if you plan to pursue this pull request? If not, we will need to close it do to inactivity. Please let us know. Thanks!

@mphilbrick211 mphilbrick211 added the inactive PR author has been unresponsive for several months label Jun 21, 2023
@Lunyachek Lunyachek force-pushed the lunyachek/fix/visual-enhancement-disabled-selects-master branch from b0553fd to 32363fc Compare June 27, 2023 10:05
@mphilbrick211 mphilbrick211 added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed inactive PR author has been unresponsive for several months labels Jul 5, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 7, 2023
@e0d
Copy link
Contributor

e0d commented Jul 7, 2023

@Lunyachek looks like there are test failures, can you have a look?

@mphilbrick211 mphilbrick211 added the inactive PR author has been unresponsive for several months label Jul 17, 2023
@mphilbrick211 mphilbrick211 added needs triage needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed inactive PR author has been unresponsive for several months labels Aug 18, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 23, 2023
@mphilbrick211
Copy link

Hi @Lunyachek - following up on this!

@mphilbrick211 mphilbrick211 added the inactive PR author has been unresponsive for several months label Sep 12, 2023
@mphilbrick211
Copy link

Hi @Lunyachek - please let us know if you plan to pursue this PR. If not, we'll close for now and can reopen should you choose to pursue at another time. Thanks!

@mphilbrick211
Copy link

Hi @openedx/revenue-squad! Is someone able to review/merge this for us?

@mphilbrick211 mphilbrick211 added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed inactive PR author has been unresponsive for several months labels Oct 3, 2023
@mphilbrick211
Copy link

Hi @openedx/revenue-squad! Is someone able to review/merge this for us?

Hi @openedx/revenue-squad! Is it possible to get an ETA on having this reviewed?

@Lunyachek Lunyachek force-pushed the lunyachek/fix/visual-enhancement-disabled-selects-master branch from 222b8ca to 0c669e4 Compare April 9, 2024 10:46
@Lunyachek
Copy link
Contributor Author

Lunyachek commented Apr 9, 2024 •
edited
Loading

@mphilbrick211, I updated this PR with suggestions from this comment - #716 (comment) and opened backport to Quince - #865

@Lunyachek Lunyachek mentioned this pull request Apr 9, 2024
Merged
feanil
feanil approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, the item is disabled but there is no indication so we update the CSS so that the disabled dropdowns look disabled visually.

@feanil
Copy link
Contributor

feanil commented Apr 11, 2024

@Lunyachek can you rebase this PR so we can get it landed?

@Lunyachek Lunyachek force-pushed the lunyachek/fix/visual-enhancement-disabled-selects-master branch from 0c669e4 to 19edd7e Compare April 18, 2024 14:58
@Lunyachek
Copy link
Contributor Author

@Lunyachek can you rebase this PR so we can get it landed?

Done

@mphilbrick211
Copy link

@feanil - this is good-to-go

@feanil feanil merged commit f59949b into openedx:master May 16, 2024
5 checks passed
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Lunyachek @openedx-webhooks @colinbrash @mphilbrick211 @e0d @feanil @itsjeyd