Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to Node 20 #1056

Merged
merged 9 commits into from
Aug 23, 2024
Merged

build: Upgrade to Node 20 #1056

merged 9 commits into from
Aug 23, 2024

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jul 25, 2024

Description

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • Updated the lockfile version check workflow

Second step in the Node 20 upgrade process, See the tracking issue for futher information.

@BilalQamar95 BilalQamar95 requested a review from a team as a code owner July 25, 2024 08:57
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.78%. Comparing base (714851c) to head (a14ff76).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1056   +/-   ##
=======================================
  Coverage   66.78%   66.78%           
=======================================
  Files          51       51           
  Lines         849      849           
  Branches      175      173    -2     
=======================================
  Hits          567      567           
  Misses        272      272           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deborahgu deborahgu added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jul 25, 2024
@BilalQamar95 BilalQamar95 marked this pull request as draft July 25, 2024 12:54
@BilalQamar95 BilalQamar95 marked this pull request as ready for review August 9, 2024 10:19
@justinhynes
Copy link
Contributor

@BilalQamar95 Looks like this one might have a conflict too 😬. Sorry!

@BilalQamar95
Copy link
Contributor Author

@BilalQamar95 Looks like this one might have a conflict too 😬. Sorry!

@justinhynes I have resolved conflicts & updated the PR

@BilalQamar95 BilalQamar95 marked this pull request as draft August 21, 2024 08:43
@BilalQamar95 BilalQamar95 changed the title feat: updated node to v20 build: Upgrade to Node 20 Aug 21, 2024
@BilalQamar95
Copy link
Contributor Author

PR will be updated and ready for review once the prerequisite PR for step 1 of the node v20 upgrade process is reviewed/merged.

@MaxFrank13
Copy link
Member

#1069 has been merged 👍

@BilalQamar95 BilalQamar95 marked this pull request as ready for review August 23, 2024 10:29
@BilalQamar95 BilalQamar95 mentioned this pull request Aug 23, 2024
@BilalQamar95 BilalQamar95 self-assigned this Aug 23, 2024
@MaxFrank13 MaxFrank13 merged commit 389d923 into master Aug 23, 2024
11 checks passed
@MaxFrank13 MaxFrank13 deleted the bilalqamar95/node-v20-upgrade branch August 23, 2024 14:27
@MaxFrank13 MaxFrank13 removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants