Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated README file to reflect template changes #918

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

Mashal-m
Copy link
Contributor

Description

The README of the MFEs needs to be updated because the frontend app template has been updated.

Issue related: openedx/wg-frontend#169

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a33966b) 66.97% compared to head (bed98e0) 66.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #918   +/-   ##
=======================================
  Coverage   66.97%   66.97%           
=======================================
  Files         128      128           
  Lines        3201     3201           
  Branches      927      927           
=======================================
  Hits         2144     2144           
  Misses       1008     1008           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m marked this pull request as ready for review October 31, 2023 08:19
@Mashal-m
Copy link
Contributor Author

Mashal-m commented Nov 1, 2023

@AfaqShuaib09 could you please merge this as well? I do not have permission.

@AfaqShuaib09
Copy link
Contributor

@AfaqShuaib09 could you please merge this as well? I do not have permission.

Hey @Mashal-m, I'm waiting for 2nd approval on your PR. I will merge it once it receives the second review.
In the meantime, Could you please rebase your brach with master? Thank you

@AfaqShuaib09 AfaqShuaib09 merged commit b268b96 into openedx:master Nov 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants