-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade react router to v6 #344
Conversation
7881ba8
to
389962f
Compare
f7a8d96
to
cd8c8b0
Compare
f67f7c1
to
8a3e6be
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 78.26% 78.26%
=======================================
Files 34 34
Lines 667 667
Branches 172 172
=======================================
Hits 522 522
Misses 132 132
Partials 13 13
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ecc578d
to
02931ab
Compare
b6fe686
to
d19c7ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! To verify, will these changes will be released as a major, breaking release?
Yes, This will be a major release. |
d19c7ec
to
01f239a
Compare
Ticket
React Router Upgrade to v6.
Description
This PR upgrades React Router from
v5
tov6
.BREAKING CHANGES
react-router-dom
fromv5
tov6
frontend-platform
fromv4
tov5
.Merge checklist:
frontend-app-learner-portal-enterprise
,frontend-app-admin-portal
, andfrontend-app-enterprise-public-catalog
). Will consumers safely be able to upgrade to this change without any breaking changes?BREAKING CHANGE
so the NPM package is released as such.Post merge:
chore(release): publish
) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.Publish from package.json
Github Action workflow to publish these new package versions to NPM.master
branch.npm view <package_name> versions --json
).