Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add Node 20 to CI matrix #408

Merged
merged 2 commits into from
Sep 3, 2024
Merged

test: Add Node 20 to CI matrix #408

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15d5b15
test: Add Node 20 to CI matrix
BilalQamar95 Aug 23, 2024
c12cbfa
refactor: updated workflow
BilalQamar95 Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,24 @@ jobs:
if: "!(github.actor == 'github-actions[bot]') "
name: Build
runs-on: ubuntu-latest
strategy:
matrix:
node: [18, 20]
continue-on-error: ${{ matrix.node == 20 }}

steps:
- name: Checkout
uses: actions/checkout@v2
with:
# pulls all commits (needed for lerna / semantic release to correctly version)
fetch-depth: 0
- name: Setup Nodejs Env
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
# pulls all tags (needed for lerna / semantic release to correctly version)
- name: Pull All Git Tags
run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
- name: Setup Nodejs
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VER }}
node-version: ${{ matrix.node }}
# lerna expects to be authenticated for publishing to NPM. This step will fail CI if NPM is not
# authenticated, even though this build does _not_ attempt to publish, as an extra check before merge
# that Lerna is set to publish.
Expand Down
Loading