feat: implement FooterSlot #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this an alternative to openedx/frontend-component-footer#405 ? |
brian-smith-tcril
force-pushed
the
implement-footerslot
branch
2 times, most recently
from
1315ea0
to
99ac684
Compare
|
@bradenmacdonald, I'd call it more of a precursor. We can still end up doing the things described there, but this is a simpler, more backward-compatible way (we hope, in particular for people that fork frontend-component-footer) to expose the footer as a slot - maybe in time for Redwood. |
brian-smith-tcril
force-pushed
the
implement-footerslot
branch
6 times, most recently
from
aee12dc
to
e6e1a40
Compare
brian-smith-tcril
force-pushed
the
implement-footerslot
branch
from
e6e1a40
to
be2692b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.