Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract: Fix extraction for es6/jsx files #75

Open
spencerhance opened this issue Aug 1, 2018 · 0 comments
Open

extract: Fix extraction for es6/jsx files #75

spencerhance opened this issue Aug 1, 2018 · 0 comments

Comments

@spencerhance
Copy link

spencerhance commented Aug 1, 2018

Django makemessages / GNU gettext do not currently support es6's template strings anywhere in a jsx file (not just in a gettext() call). Since it doesn't appear that gettext has any plans to add this support, we should really find a workaround or another library.

Bug reports:

Having backticks in the file causes xgettext's parsing to break, printing a few warnings in the log about unterminated strings or regexes. Additionally, it will complete the parsing but miss many gettext strings, leading to incomplete .po files.

Jira ticket:
https://openedx.atlassian.net/browse/LEARNER-6038

@spencerhance spencerhance changed the title extract: Find another extraction library for es6/jsx files extract: Fix extraction for es6/jsx files Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant