Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add catalog info for backstage #130

Merged

Conversation

brian-smith-tcril
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d749793) 99.47% compared to head (dc14a93) 99.47%.

❗ Current head dc14a93 differs from pull request most recent head 1f1d850. Consider uploading reports for the commit 1f1d850 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          10       10           
  Lines         381      381           
  Branches       28       28           
=======================================
  Hits          379      379           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things you can get rid of but then I think this is good to land. I don't need another review if you are dropping those too things I pointed out.

title: "Source Code"
icon: "Code"
annotations:
github.com/project-slug: openedx/i18n-tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name: 'i18n-tools'
description: "Tools to help with internationalization and localization of Open edX projects"
links:
- url: "https://github.com/openedx/i18n-tools"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets auto linked so you don't need to do it explicitly.

@brian-smith-tcril
Copy link
Contributor Author

@feanil just to confirm before I update this

apiVersion: backstage.io/v1alpha1
kind: Component
metadata:
  name: 'i18n-tools'
  description: "Tools to help with internationalization and localization of Open edX projects"
spec:
  owner: domain-translations
  type: 'library'
  lifecycle: 'production'

is all we need?

@feanil
Copy link
Contributor

feanil commented Jul 12, 2023

Yep, that looks right to me.

@brian-smith-tcril brian-smith-tcril force-pushed the add-catalog-info branch 2 times, most recently from 472ee4b to dc14a93 Compare July 13, 2023 19:39
@brian-smith-tcril brian-smith-tcril merged commit 7157731 into openedx:master Jul 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants