feat: add python 3.11 support #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 11 11
Lines 461 461
Branches 33 33
=======================================
Hits 460 460
Partials 1 1 ☔ View full report in Codecov by Sentry. |
awais786
force-pushed
the
jenkins/add-python312-support-a2cccea
branch
from
3b09999
to
c1cb129
Compare
UsamaSadiq
reviewed
Apr 1, 2024
tox.ini
Outdated
|
|
||
| [pytest] | ||
| addopts = --cov=tests --cov-report term --cov-config=.coveragerc -p no:randomly | ||
| testpaths = tests | ||
|
|
||
| [testenv] | ||
| download = true |
There was a problem hiding this comment.
Please add a comment why this flag is needed?
UsamaSadiq
reviewed
Apr 1, 2024
requirements/common_constraints.txt
Outdated
| # In edx-lint, until the pyjwt constraint in edx-lint has been removed. | ||
| # See BOM-2721 for more details. | ||
| # Below is the copied and edited version of common_constraints | ||
|
|
There was a problem hiding this comment.
It seems like an issue with the common_constraints.txt file as it haven't been updated and latest constraints have not been fetched properly. Perhaps try running make upgrade again.
feanil
reviewed
Apr 3, 2024
feanil
approved these changes
Apr 8, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the details, check the issue openedx/public-engineering#233
With python3.12 it has some failures so for this PR 3.11 is enough.