Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rebuilding the requirements with new constraint #150

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

deborahgu
Copy link
Member

@deborahgu deborahgu commented Jul 30, 2024

setup.py has a load_requirements method which gives install_requires a list of packages to install. The logic was not respecting constraints. However, we have modified this method elsewhere in the code base to respect constraints, so I updated accordingly.

because this is consumed as a package, the requirements need to be
built manually.
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (01e9c87) to head (3235d4e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          11       11           
  Lines         461      461           
  Branches       33       33           
=======================================
  Hits          460      460           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinhynes
Copy link

I think we still want to bump the version here too.

def __init__(self):
self.args = sys.argv[1:]
self.configuration = None
self.parser = argparse.ArgumentParser()
self.parser.add_argument(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything from here on down was just automatic lint.


from setuptools import setup


def load_requirements(*requirements_paths):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taken from https://github.com/openedx/xblock-sdk/blob/master/setup.py. everything below this method is just linter.

Copy link

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, good find on the setup.py needing to be updated.

bad typing
@deborahgu deborahgu merged commit 2649635 into master Jul 30, 2024
2 of 6 checks passed
@deborahgu deborahgu deleted the dkaplan1/pin-Path-take3 branch July 30, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants