Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codecov, replace with python-coverage-comment-action #300

Closed
wants to merge 3 commits into from
Closed

Remove codecov, replace with python-coverage-comment-action #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a635f4e
build: replace codecov with python-coverage-comment-action
nedbat Jan 9, 2024
3df7504
temp: bogus code that isn't run
nedbat Jan 9, 2024
5fa8d1e
relative_files
nedbat Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
[run]
branch = True
relative_files = True
data_file = .coverage
source=openedx_events
omit =
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,12 @@ jobs:
TOXENV: ${{ matrix.toxenv }}
run: tox

- name: Run coverage
- name: Report coverage
if: matrix.python-version == '3.8' && matrix.toxenv == 'py38'
uses: codecov/codecov-action@v3
uses: py-cov-action/python-coverage-comment-action@v3
with:
flags: unittests
fail_ci_if_error: true
GITHUB_TOKEN: ${{ github.token }}
MINIMUM_GREEN: 90
MINIMUM_ORANGE: 85
ANNOTATE_MISSING_LINES: true
ANNOTATION_TYPE: error
5 changes: 5 additions & 0 deletions openedx_events/tests/test_tooling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,3 +377,8 @@
OpenEdxPublicSignal.get_signal_by_type('org.openedx.learning.course.enrollment.created.v1'),
OpenEdxPublicSignal
)


class SirNotAppearingInThisFilm(TestCase):
def never_run(self):
print("Hello")

Check failure on line 384 in openedx_events/tests/test_tooling.py

View workflow job for this annotation

GitHub Actions / tests (ubuntu-20.04, 3.8, py38)

Missing coverage 

Missing coverage on line 384
Loading